adamdebreceni commented on a change in pull request #943:
URL: https://github.com/apache/nifi-minifi-cpp/pull/943#discussion_r532415163
##########
File path: extensions/standard-processors/processors/GetTCP.h
##########
@@ -212,29 +207,29 @@ class GetTCP : public core::Processor, public
state::response::MetricsNodeSource
* @param sessionFactory process session factory that is used when creating
* ProcessSession objects.
*/
- virtual void onSchedule(const std::shared_ptr<core::ProcessContext>
&processContext, const std::shared_ptr<core::ProcessSessionFactory>
&sessionFactory);
+ void onSchedule(const std::shared_ptr<core::ProcessContext> &processContext,
const std::shared_ptr<core::ProcessSessionFactory> &sessionFactory) override;
- void onSchedule(core::ProcessContext *processContext,
core::ProcessSessionFactory *sessionFactory) {
- throw std::exception();
+ void onSchedule(core::ProcessContext *processContext,
core::ProcessSessionFactory *sessionFactory) override {
+ throw std::logic_error{"GetTCP::onSchedule(ProcessContext*,
ProcessSessionFactory*) is unimplemented"};
Review comment:
I kind of get the reason behind this `onSchedule` overload, but
shouldn't we overload the raw-pointer-taking `onSchedule` (unless the processor
wants to store the context or factory) and leave the
`onSchedule(shared_ptr<ProcessContext>, shared_ptr<ProcessSessionFactory>)`
alone (defaulting to forwarding to the raw-pointer-taking `onSchedule` in
`Processor`), then we wouldn't have to throw at all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
