adamdebreceni commented on a change in pull request #937:
URL: https://github.com/apache/nifi-minifi-cpp/pull/937#discussion_r533968416
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -23,7 +23,7 @@
#include <cstring>
#include <functional>
#ifdef WIN32
- #include <cwctype>
+#include <cwctype>
Review comment:
indeed, it was unintentional, fixed
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -143,6 +146,12 @@ class StringUtils {
return std::equal(endString.rbegin(), endString.rend(), value.rbegin(),
[](unsigned char lc, unsigned char rc) {return tolower(lc) == tolower(rc);});
}
+ inline static bool startsWith(const std::string &value, const std::string &
startString) {
Review comment:
done, and for `endsWith` as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
