markap14 commented on a change in pull request #4685: URL: https://github.com/apache/nifi/pull/4685#discussion_r534465100
########## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java ########## @@ -53,6 +54,66 @@ public TestRunner getRunner() { return runner; } Review comment: I'm not sure that I follow your suggestion. I feel it is quite heavily tested at this point. Can you provide an example configuration that you think would be worthwhile testing? As in, provide a set of: Search Value = ___ Replacement Value = ___ Replacement Strategy = ___ Sample input = ____ Expected output = ____ ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org