fgerlits commented on a change in pull request #950:
URL: https://github.com/apache/nifi-minifi-cpp/pull/950#discussion_r536135645
##########
File path: cmake/BundledCivetWeb.cmake
##########
@@ -30,8 +30,8 @@ function(use_bundled_civetweb SOURCE_DIR BINARY_DIR)
endif()
set(BYPRODUCTS
- "lib/${PREFIX}civetweb.${SUFFIX}"
- "lib/${PREFIX}civetweb-cpp.${SUFFIX}"
+ "${CMAKE_INSTALL_LIBDIR}/${PREFIX}civetweb.${SUFFIX}"
+ "${CMAKE_INSTALL_LIBDIR}/${PREFIX}civetweb-cpp.${SUFFIX}"
Review comment:
yeah -- that makes me wonder if adding `-DCMAKE_INSTALL_LIBDIR=lib` (as
is done in BundledLibRdKafka) would be a better solution
but I think either way is fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
