szaszm commented on a change in pull request #947: URL: https://github.com/apache/nifi-minifi-cpp/pull/947#discussion_r538632918
########## File path: libminifi/src/utils/tls/ExtendedKeyUsage.cpp ########## @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifdef OPENSSL_SUPPORT + +#include "utils/tls/ExtendedKeyUsage.h" + +#include <openssl/x509v3.h> + +#include <array> +#include <cassert> +#include <climits> + +#include "core/logging/LoggerConfiguration.h" +#include "utils/StringUtils.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { +namespace tls { + +namespace { + +struct KeyValuePair { + const char* key; + uint8_t value; +}; +constexpr std::array<KeyValuePair, 6> EXT_KEY_USAGE_NAME_TO_BIT_POS{{ + KeyValuePair{"Server Authentication", 1}, + KeyValuePair{"Client Authentication", 2}, + KeyValuePair{"Code Signing", 3}, + KeyValuePair{"Secure Email", 4}, + KeyValuePair{"Time Stamping", 8}, + KeyValuePair{"OCSP Signing", 9} +}}; + +} // namespace + +void EXTENDED_KEY_USAGE_deleter::operator()(EXTENDED_KEY_USAGE* key_usage) const { EXTENDED_KEY_USAGE_free(key_usage); } + +ExtendedKeyUsage::ExtendedKeyUsage() : logger_(core::logging::LoggerFactory<ExtendedKeyUsage>::getLogger()) {} + +ExtendedKeyUsage::ExtendedKeyUsage(const EXTENDED_KEY_USAGE& key_usage_asn1) : ExtendedKeyUsage{} { + const int num_oids = sk_ASN1_OBJECT_num(&key_usage_asn1); + for (int i = 0; i < num_oids; ++i) { + const ASN1_OBJECT* const oid = sk_ASN1_OBJECT_value(&key_usage_asn1, i); + assert(oid && oid->length > 0); + const unsigned char bit_pos = oid->data[oid->length - 1]; Review comment: My problem is that I couldn't find a source that describes the structure of extended key usage asn1 objects in detail. I don't understand why we index to the last element (byte?) of the object and why it contains the bit position that we use below. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
