[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #958: MINIFICPP-1432 Remove the timing-sensitivity of NetworkPrioritizerServiceTests

[GitBox]

adamdebreceni commented on a change in pull request #958:
URL: https://github.com/apache/nifi-minifi-cpp/pull/958#discussion_r542420260



##########
File path: libminifi/include/controllers/NetworkPrioritizerService.h
##########
@@ -121,6 +126,7 @@ class NetworkPrioritizerService : public 
core::controller::ControllerService, pu
   bool verify_interfaces_;
 
  private:
+  std::shared_ptr<utils::timeutils::Clock> clock_;

Review comment:
       in the tests the clock is being advanced externally (if this is the only 
reason, we should create a TestAccessor, and switch to `unique_ptr`)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org