lordgamez commented on a change in pull request #959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r544183525
##########
File path: libminifi/test/persistence-tests/PersistenceTests.cpp
##########
@@ -326,11 +335,15 @@ TEST_CASE("Persisted flowFiles are updated on
modification", "[TestP1]") {
ff_repository->start();
// wait for FlowFileRepository to start and notify the owners of
// the resurrected FlowFiles
- std::this_thread::sleep_for(std::chrono::milliseconds{100});
-
+ std::this_thread::sleep_for(std::chrono::milliseconds(100));
Review comment:
Added log checks instead of sleeps in the PersistenceTests in
[eaf4925](https://github.com/apache/nifi-minifi-cpp/pull/959/commits/eaf49254954dcbc12125b1d9d14aa7be829b7d97).
Checking for "Found connection for" log entry which indicates a the restore
procedure to be taken place seems to be working for our case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
