Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1103#discussion_r81986163
  
    --- Diff: .github/PULL_REQUEST_TEMPLATE.md ---
    @@ -0,0 +1,32 @@
    +<!--
    +  Licensed to the Apache Software Foundation (ASF) under one or more
    +  contributor license agreements.  See the NOTICE file distributed with
    +  this work for additional information regarding copyright ownership.
    +  The ASF licenses this file to You under the Apache License, Version 2.0
    +  (the "License"); you may not use this file except in compliance with
    +  the License.  You may obtain a copy of the License at
    +      http://www.apache.org/licenses/LICENSE-2.0
    +  Unless required by applicable law or agreed to in writing, software
    +  distributed under the License is distributed on an "AS IS" BASIS,
    +  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  See the License for the specific language governing permissions and
    +  limitations under the License.
    +-->
    +
    +Thank you for submiting a contribution to Apache NiFi.
    +
    +In order to streamline the review of the contribution we ask you
    +to ensure the follow steps have been taken:
    +
    +### For all changes:
    +- [] Is there a JIRA ticket associated with this PR? Is is referenced 
    --- End diff --
    
    Pretty much the same thing as the commit message.  It's less important if 
it is in the commit, but is nice to see kind of a uniform representation of the 
issue in the overall PR listings.  
    
    At least in my experiences if I create a commit:
    "NIFI-XXXX Blah blah blah"
    
    and then subsequently create a PR, Github defaults the title to:
    
    "Nifi XXXX Blah blah blah..."
    
    That hyphen is critical in terms of our associated triggers being able to 
link to issues in JIRA.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to