exceptionfactory commented on a change in pull request #4747:
URL: https://github.com/apache/nifi/pull/4747#discussion_r554015409
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java
##########
@@ -204,7 +206,7 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
try {
contextMap.complete(contextIdentifier);
- } catch (final IllegalStateException ise) {
+ } catch (final RuntimeException ise) {
Review comment:
Renamed to `ce` as requested.
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpResponse.java
##########
@@ -194,7 +192,11 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
} catch (final ProcessException e) {
session.transfer(flowFile, REL_FAILURE);
getLogger().error("Failed to respond to HTTP request for {} due to
{}", new Object[]{flowFile, e});
- contextMap.complete(contextIdentifier);
+ try {
Review comment:
That makes sense, reordered this and other `session.transfer()` calls to
occur after logging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
