szaszm edited a comment on pull request #983:
URL: https://github.com/apache/nifi-minifi-cpp/pull/983#issuecomment-771666092


   I also thought about it, but didn't want to delay the release with this 
issue. I can create a Jira issue to track this.
   
   I made an attempt to convert msi/LICENSE.txt to a symlink, but on Windows it 
got checked out as a text file containing the link destination. Newer git 
versions should support symlinks, but I figured if it doesn't work everywhere 
(or anywhere by default), it's better to keep it copied as we don't want people 
accidentally generating MSIs with "../LICENSE" as their license text.
   
   [[MINIFICPP-1496] Ensure that the MSI installer always shows 
LICENSE](https://issues.apache.org/jira/browse/MINIFICPP-1469)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to