exceptionfactory commented on a change in pull request #4804:
URL: https://github.com/apache/nifi/pull/4804#discussion_r569680427
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -474,6 +475,16 @@
.allowableValues("true", "false")
.build();
+ public static final PropertyDescriptor SUPPORT_HTTP2_PROTOCOL = new
PropertyDescriptor.Builder()
+ .name("support-http2")
+ .description("Determines whether or not to support the HTTP 2
protocol version.")
+ .displayName("Support HTTP 2")
+ .required(true)
+ .defaultValue("True")
+ .allowableValues("True", "False")
Review comment:
Should Boolean values be lowercase strings to match standard primitive
usage and other Boolean properties?
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -474,6 +475,16 @@
.allowableValues("true", "false")
.build();
+ public static final PropertyDescriptor SUPPORT_HTTP2_PROTOCOL = new
PropertyDescriptor.Builder()
+ .name("support-http2")
+ .description("Determines whether or not to support the HTTP 2
protocol version.")
Review comment:
Recommend a slight wording change to use `HTTP/2` instead of `HTTP 2` in
order to match official naming conventions.
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -474,6 +475,16 @@
.allowableValues("true", "false")
.build();
+ public static final PropertyDescriptor SUPPORT_HTTP2_PROTOCOL = new
PropertyDescriptor.Builder()
+ .name("support-http2")
+ .description("Determines whether or not to support the HTTP 2
protocol version.")
+ .displayName("Support HTTP 2")
Review comment:
Recommend rewording to `Support HTTP/2`
```suggestion
.displayName("Support HTTP/2")
```
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -743,6 +755,12 @@ public void setUpClient(final ProcessContext context)
throws TlsException {
okHttpClientBuilder.cache(new Cache(getETagCacheDir(),
maxCacheSizeBytes));
}
+ if(context.getProperty(SUPPORT_HTTP2_PROTOCOL).asBoolean()) {
Review comment:
Should there be a space after the `if`?
```suggestion
if (context.getProperty(SUPPORT_HTTP2_PROTOCOL).asBoolean()) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
