Lehel44 commented on a change in pull request #4754: URL: https://github.com/apache/nifi/pull/4754#discussion_r573018147
########## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/cosmos/document/GetAzureCosmosDBRecord.java ########## @@ -0,0 +1,266 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.nifi.processors.azure.cosmos.document; + +import java.io.IOException; +import java.io.OutputStream; +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.atomic.AtomicLong; + +import com.azure.cosmos.CosmosContainer; +import com.azure.cosmos.models.CosmosQueryRequestOptions; +import com.azure.cosmos.util.CosmosPagedIterable; +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.JsonNode; +import com.fasterxml.jackson.databind.ObjectMapper; + +import org.apache.nifi.annotation.behavior.InputRequirement; +import org.apache.nifi.annotation.behavior.InputRequirement.Requirement; +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.components.ValidationContext; +import org.apache.nifi.components.ValidationResult; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.flowfile.attributes.CoreAttributes; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.schema.access.SchemaNotFoundException; +import org.apache.nifi.serialization.RecordSetWriter; +import org.apache.nifi.serialization.RecordSetWriterFactory; +import org.apache.nifi.serialization.record.MapRecord; +import org.apache.nifi.serialization.record.Record; +import org.apache.nifi.serialization.record.RecordSchema; + + +@Tags({ "azure", "cosmos", "record", "read", "fetch" }) +@InputRequirement(Requirement.INPUT_ALLOWED) +@CapabilityDescription("A record-oriented GET processor that uses the record writers to write the Azure Cosmos SQL select query result set.") +public class GetAzureCosmosDBRecord extends AbstractAzureCosmosDBProcessor { + public static final PropertyDescriptor WRITER_FACTORY = new PropertyDescriptor.Builder() + .name("record-writer-factory") + .displayName("Record Writer") + .description("The record writer to use to write the result sets") + .identifiesControllerService(RecordSetWriterFactory.class) + .required(true) + .build(); + public static final PropertyDescriptor SCHEMA_NAME = new PropertyDescriptor.Builder() + .name("schema-name") + .displayName("Schema Name") + .description("The name of the schema in the configured schema registry to use for the query results") + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .addValidator(StandardValidators.NON_BLANK_VALIDATOR) + .defaultValue("${schema.name}") + .required(true) + .build(); + + public static final PropertyDescriptor QUERY = new PropertyDescriptor.Builder() + .name("sql-core-document-query") + .displayName("SQL Core Document Query") + .description("The SQL select query to execute. " + + "This should be a valid SQL select query to Cosmos DB with core sql api") + .required(true) + .addValidator(StandardValidators.NON_BLANK_VALIDATOR) + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .build(); + + public static final PropertyDescriptor MAX_RESPONSE_PAGE_SIZE = new PropertyDescriptor.Builder() + .name("max-page-size") + .displayName("Max Page Size") + .description("The maximum number of elements in a response page from Cosmos DB") + .required(false) + .expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES) + .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR) + .defaultValue("10") + .build(); + + private final static Set<Relationship> relationships; + private final static List<PropertyDescriptor> propertyDescriptors; + private ComponentLog logger; + private final static ObjectMapper mapper; + + static { + List<PropertyDescriptor> _propertyDescriptors = new ArrayList<>(); + _propertyDescriptors.addAll(descriptors); + _propertyDescriptors.add(QUERY); + _propertyDescriptors.add(WRITER_FACTORY); + _propertyDescriptors.add(SCHEMA_NAME); + _propertyDescriptors.add(MAX_RESPONSE_PAGE_SIZE); + propertyDescriptors = Collections.unmodifiableList(_propertyDescriptors); + + final Set<Relationship> _relationships = new HashSet<>(); + _relationships.add(REL_SUCCESS); + _relationships.add(REL_FAILURE); + _relationships.add(REL_ORIGINAL); + relationships = Collections.unmodifiableSet(_relationships); + mapper = new ObjectMapper(); + } + + @Override + public Set<Relationship> getRelationships() { + return relationships; + } + + @Override + public final List<PropertyDescriptor> getSupportedPropertyDescriptors() { + return propertyDescriptors; + } + + @Override + protected Collection<ValidationResult> customValidate(ValidationContext context) { + Collection<ValidationResult> result = super.customValidate(context); + + boolean queryIsSet = context.getProperty(QUERY).isSet(); + if (!queryIsSet) { + final String msg = QUERY.getDisplayName() + " must be set."; + result.add(new ValidationResult.Builder().valid(false).explanation(msg).build()); + } + return result; + } + + private String getQuery(ProcessContext context, ProcessSession session, FlowFile input) { + String query = null; + + if (context.getProperty(QUERY).isSet()) { + query = context.getProperty(QUERY).evaluateAttributeExpressions(input).getValue(); + } else if (!context.getProperty(QUERY).isSet() && input == null) { + query = "select top 100 * from c"; + } + return query; + } + + private Map<String, String> getAttributes(ProcessContext context, FlowFile input) { + final Map<String, String> attributes = new HashMap<>(); + + attributes.put(CoreAttributes.MIME_TYPE.key(), "application/json"); + + if (context.getProperty(QUERY).isSet()) { + final String query = context.getProperty(QUERY).evaluateAttributeExpressions(input).getValue(); + attributes.put("query", query); + } + return attributes; + } + + @Override + public void onTrigger(final ProcessContext context, final ProcessSession session) throws ProcessException { + this.writerFactory =context.getProperty(WRITER_FACTORY).asControllerService(RecordSetWriterFactory.class); + + final FlowFile input = context.hasIncomingConnection() ? session.get() : null; + logger = getLogger(); + + if (input == null && context.hasNonLoopConnection()) { + if (logger.isDebugEnabled()) { + logger.debug("No flowfile input and NonLoopConnection. Ending onTrigger... "); + } + return; + } + final String query = getQuery(context, session, input); + final Map<String, String> attributes = getAttributes(context, input); + if (logger.isDebugEnabled()) { + logger.debug("Running Cosmos SQL query : " + query); + } + final CosmosQueryRequestOptions queryOptions = new CosmosQueryRequestOptions(); + final CosmosContainer container = getContainer(); + final CosmosPagedIterable<JsonNode> response = container != null + ? container.queryItems(query, queryOptions, JsonNode.class) + : null; + if (response == null) { + logger.error("Fails to get CosmosPagedIterable<JsonNode> response"); + if (input != null) { + session.transfer(input, REL_FAILURE); + } + return; + } + FlowFile output = input != null ? session.create(input) : session.create(); + try { + logger.debug("Start to process data from Azure Cosmos DB"); + final String schemaName = context.getProperty(SCHEMA_NAME).evaluateAttributeExpressions(input).getValue(); + try (OutputStream out = session.write(output)) { + Map<String, String> attrs = input != null ? input.getAttributes() : new HashMap<String, String>(){{ + put("schema.name", schemaName); + }}; + RecordSchema schema = writerFactory.getSchema(attrs, null); + RecordSetWriter writer = writerFactory.createWriter(getLogger(), schema, out, attrs); + final AtomicLong count = new AtomicLong(); + writer.beginRecordSet(); + + response.forEach(data ->{ + try { + Map<String,Object> mapObj = mapper.convertValue(data, new TypeReference<Map<String, Object>>(){}); + Record record = new MapRecord(schema, mapObj); + writer.write(record); + } catch(IOException | IllegalArgumentException ex) { + throw new RuntimeException(ex); + } + count.incrementAndGet(); + }); + writer.finishRecordSet(); + writer.close(); + out.close(); + attributes.put("record.count", String.valueOf(count.get())); + } catch (SchemaNotFoundException e) { + throw new RuntimeException(e); + } Review comment: I'd recommend a little refactor here, to break down the complexity of this method. I'd extract the nested try block and the map initialization. ```suggestion private void processSession(ProcessSession session, FlowFile input, Map<String, String> attributes, CosmosPagedIterable<JsonNode> response, FlowFile output, String schemaName) throws IOException { final Map<String, String> attributeMap = initAttributeMap(input, schemaName); try (OutputStream out = session.write(output)) { RecordSchema schema = writerFactory.getSchema(attributeMap, null); RecordSetWriter writer = writerFactory.createWriter(getLogger(), schema, out, attributeMap); final AtomicLong count = new AtomicLong(); writer.beginRecordSet(); response.forEach(data -> processData(schema, writer, count, data)); writer.finishRecordSet(); writer.close(); attributes.put("record.count", String.valueOf(count.get())); } catch (SchemaNotFoundException e) { throw new RuntimeException(e); } } private void processData(RecordSchema schema, RecordSetWriter writer, AtomicLong count, JsonNode data) { try { Map<String,Object> mapObj = mapper.convertValue(data, new TypeReference<Map<String, Object>>(){}); Record record = new MapRecord(schema, mapObj); writer.write(record); } catch(IOException | IllegalArgumentException ex) { throw new RuntimeException(ex); } count.incrementAndGet(); } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
