[
https://issues.apache.org/jira/browse/MINIFICPP-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1496:
--------------------------------------
Description:
If you select option 2, "Enable all extensions", in bootstrap.sh, then "Create
ASAN build" gets enabled, too. It is easy to disable it, by selecting option
6, but it is also easy to not notice that it got selected, and create a build
which has address sanitizer enabled by accident.
Since address sanitizer not an extension, and production builds should never
have it enabled, option 2 should not enable it.
The same applies to "Enable JNI Support", this is not an extension, either.
EDIT: fixing ENABLE_JNI would be more complicated though, as selecting this
also triggers fetching certain packages in the distro-specific scripts
(debian.sh, centos.sh etc), which depend on the variable being included in the
OPTIONS list (that is what "Enable all extensions" adds the variable to). For
now, I have decided against fixing ENABLE_JNI, and will only fix ASAN_BUILD.
was:
If you select option 2, "Enable all extensions", in bootstrap.sh, then "Create
ASAN build" gets enabled, too. It is easy to disable it, by selecting option
6, but it is also easy to not notice that it got selected, and create a build
which has address sanitizer enabled by accident.
Since address sanitizer not an extension, and production builds should never
have it enabled, option 2 should not enable it.
The same applies to "Enable JNI Support", this is not an extension, either.
> "Enable all extensions" in boostrap.sh should not enable ASAN
> -------------------------------------------------------------
>
> Key: MINIFICPP-1496
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1496
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Ferenc Gerlits
> Assignee: Ferenc Gerlits
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If you select option 2, "Enable all extensions", in bootstrap.sh, then
> "Create ASAN build" gets enabled, too. It is easy to disable it, by
> selecting option 6, but it is also easy to not notice that it got selected,
> and create a build which has address sanitizer enabled by accident.
> Since address sanitizer not an extension, and production builds should never
> have it enabled, option 2 should not enable it.
> The same applies to "Enable JNI Support", this is not an extension, either.
> EDIT: fixing ENABLE_JNI would be more complicated though, as selecting this
> also triggers fetching certain packages in the distro-specific scripts
> (debian.sh, centos.sh etc), which depend on the variable being included in
> the OPTIONS list (that is what "Enable all extensions" adds the variable to).
> For now, I have decided against fixing ENABLE_JNI, and will only fix
> ASAN_BUILD.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
