turcsanyip commented on a change in pull request #4813:
URL: https://github.com/apache/nifi/pull/4813#discussion_r580302386
##########
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/provenance/StandardAnalysisContext.java
##########
@@ -37,13 +37,15 @@
private final NamespaceResolver namespaceResolver;
private final ProvenanceRepository provenanceRepository;
private final String awsS3ModelVersion;
+ private final FilesystemPathsLevel filesystemPathsLevel;
public StandardAnalysisContext(NiFiFlow nifiFlow, NamespaceResolver
namespaceResolver,
- ProvenanceRepository provenanceRepository,
String awsS3ModelVersion) {
Review comment:
In general, I do not prefer using `final` for local variables and
parameters. All these variables should be final in most cases and IDEs can mark
it automatically if a variable is used in a non final way.
For existing codes I follow the existing pattern in the class/method and
only add `final` if it is already used there.
This parameter list does not use `final`-s so I would not add it for the new
param either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
