exceptionfactory commented on a change in pull request #4836:
URL: https://github.com/apache/nifi/pull/4836#discussion_r582180703
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/flow/TestPopularVoteFlowElection.java
##########
@@ -157,7 +158,7 @@ public void testEmptyFlowIgnoredIfNonEmptyFlowExists()
throws IOException {
@Test
public void testAutoGeneratedVsPopulatedFlowElection() throws IOException {
final ExtensionManager extensionManager = new
StandardExtensionDiscoveringManager();
- final FingerprintFactory fingerprintFactory = new
FingerprintFactory(createEncryptorFromProperties(getNiFiProperties()),
extensionManager);
+ final FingerprintFactory fingerprintFactory = new
FingerprintFactory(createEncryptorFromProperties(getNiFiProperties()),
extensionManager, SecureHasherFactory.getSecureHasher());
Review comment:
If the performance of the existing SecureHashers is roughly similar for
unit tests, than just directly instantiating one here for testing is probably
the easiest approach. For best performance, using Mockito to mock
`SecureHasher` and return a hard-coded result might be worth considering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
