Github user jvwing commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1112#discussion_r82451044
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/factory/strategies/AssumeRoleCredentialsStrategy.java
---
@@ -113,16 +134,34 @@ public AWSCredentialsProvider
getDerivedCredentialsProvider(Map<PropertyDescript
rawMaxSessionTime = (rawMaxSessionTime != null) ?
rawMaxSessionTime : MAX_SESSION_TIME.getDefaultValue();
final Integer maxSessionTime =
Integer.parseInt(rawMaxSessionTime.trim());
final String assumeRoleExternalId =
properties.get(ASSUME_ROLE_EXTERNAL_ID);
+ STSAssumeRoleSessionCredentialsProvider.Builder builder;
+
+ // If proxy variables are set, then create Client Configuration
with those values
+ if (proxyVariablesValidForAssumeRole(properties)) {
+ final String assumeRoleProxyHost =
properties.get(ASSUME_ROLE_PROXY_HOST);
+ final Integer assumeRoleProxyPort =
Integer.parseInt(properties.get(ASSUME_ROLE_PROXY_PORT));
+ ClientConfiguration config = new ClientConfiguration();
+ config.withProxyHost(assumeRoleProxyHost);
+ config.withProxyPort(assumeRoleProxyPort);
+ AWSSecurityTokenService securityTokenService = new
AWSSecurityTokenServiceClient(config);
--- End diff --
Your point about `withLongLivedCredentialsProvider` being deprecated is a
good one. I was thinking of refactoring both cases to use the STS client like
this:
STSAssumeRoleSessionCredentialsProvider.Builder builder;
ClientConfiguration config = new ClientConfiguration();
// If proxy variables are set, then create Client Configuration
with those values
if (proxyVariablesValidForAssumeRole(properties)) {
final String assumeRoleProxyHost =
properties.get(ASSUME_ROLE_PROXY_HOST);
final Integer assumeRoleProxyPort =
Integer.parseInt(properties.get(ASSUME_ROLE_PROXY_PORT));
config.withProxyHost(assumeRoleProxyHost);
config.withProxyPort(assumeRoleProxyPort);
}
AWSSecurityTokenService securityTokenService = new
AWSSecurityTokenServiceClient(primaryCredentialsProvider, config);
builder = new STSAssumeRoleSessionCredentialsProvider
.Builder(assumeRoleArn, assumeRoleName)
.withStsClient(securityTokenService)
.withRoleSessionDurationSeconds(maxSessionTime);
if (assumeRoleExternalId != null &&
!assumeRoleExternalId.isEmpty()) {
builder = builder.withExternalId(assumeRoleExternalId);
}
final AWSCredentialsProvider credsProvider = builder.build();
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
