[GitHub] [nifi] pvillard31 commented on pull request #4846: NIFI-8260 Implement an Upload File capability in the NiFi UI for flow definitions.

[GitBox]

pvillard31 commented on pull request #4846:
URL: https://github.com/apache/nifi/pull/4846#issuecomment-786855079


   Note sure if this has been addressed but I noticed that: if selecting a flow 
on the canvas ans clicking on the "Group" icon (to make a process group from 
the selection), then the icon to upload a JSON file appears when it should just 
ask for the new process group to create from the selection.
   
   <img width="1407" alt="Screenshot 2021-02-26 at 23 36 54" 
src="https://user-images.githubusercontent.com/11541012/109346830-ad681980-788b-11eb-9793-891cb90fe332.png";>
   
   <img width="450" alt="Screenshot 2021-02-26 at 23 37 38" 
src="https://user-images.githubusercontent.com/11541012/109346855-b48f2780-788b-11eb-9b06-e8162451f9b7.png";>
   
   I don't think this is expected. And if I do select a JSON file at this step 
(instead of just giving a name for my selection to be added in a process 
group), the process group for my JSON file will be added instead of putting my 
selection into a process group.
   
   So... I guess it's just about removing the option to upload the file when we 
click on the "Group" button. It should only be available when drag-and-dropping 
a process group on the canvas. Thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org