turcsanyip commented on a change in pull request #4825:
URL: https://github.com/apache/nifi/pull/4825#discussion_r584551485
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateRecord.java
##########
@@ -172,22 +172,24 @@
static final PropertyDescriptor STRICT_TYPE_CHECKING = new
PropertyDescriptor.Builder()
.name("strict-type-checking")
.displayName("Strict Type Checking")
- .description("If the incoming data has a Record where a field is not
of the correct type, this property determine whether how to handle the Record. "
- + "If true, the Record will still be considered invalid. If false,
the Record will be considered valid and the field will be coerced into the "
- + "correct type (if possible, according to the type coercion
supported by the Record Writer).")
+ .description("If the incoming data has a Record where a field is not
of the correct type, this property determines how to handle the Record. "
+ + "If true, the Record will be considered invalid. If false, the
Record will be considered valid and the field will be coerced into the "
+ + "correct type (if possible, according to the type coercion
supported by the Record Writer). "
+ + "This property controls how the data is validated against the
validation schema.")
.expressionLanguageSupported(ExpressionLanguageScope.NONE)
.allowableValues("true", "false")
.defaultValue("true")
.required(true)
.build();
static final PropertyDescriptor COERCE_TYPES = new
PropertyDescriptor.Builder()
.name("coerce-types")
- .displayName("Force Types From Schema")
- .description("If enabled, the processor will coerce every field to
the type specified in the schema. "
- + "If the value of the field cannot be coerced to the type,
the field will be skipped and will not "
- + "appear in the output. "
+ .displayName("Force Types From Reader's Schema")
+ .description("If enabled, the processor will coerce every field to
the type specified in the Reader's schema. "
+ + "If the value of a field cannot be coerced to the type, the
field will be skipped (will not be read from the input data), "
+ + "thus will not appear in the output. "
+ "If not enabled, then every field will appear in the output
but their types may differ from what is "
- + "specified in the schema. For details please see the
Additional Details page of the processor's Help.")
+ + "specified in the schema. For details please see the
Additional Details page of the processor's Help."
+ + "This property controls how the data is read by the
specified Record Reader.")
Review comment:
Missing space before the sentence.
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/resources/docs/org.apache.nifi.processors.standard.ValidateRecord/additionalDetails.html
##########
@@ -29,13 +29,23 @@
<h2>Examples for the effect of Force Types From Schema property</h2>
<p>
- The value of the Force Types From Schema property has an effect on what
+ The processor first reads the data from the incoming FlowFile using the
specified Record Reader,
+ which uses a schema. Then, depending on the value of the Schema Access
Strategy property, the processor
+ can either use the reader's schema, or a different schema to validate the
data against.
+ After that, the processor writes the data into the outgoing FlowFile using
the specified
+ Record Writer. If the data is valid, the validation schema is used by the
writer.
+ If the data is invalid, the writer uses the reader's schema.
+ The <b>Force Types From Schema</b> property affects the first step:
Review comment:
Property name has changed: `Force Types From Reader's Schema`
It should be refreshed in this doc too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
