lordgamez commented on a change in pull request #979: URL: https://github.com/apache/nifi-minifi-cpp/pull/979#discussion_r585336114
########## File path: extensions/azure/AzureLoader.h ########## @@ -0,0 +1,69 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <vector> +#include <string> +#include <memory> + +#include "core/ClassLoader.h" +#include "utils/StringUtils.h" +#include "utils/GeneralUtils.h" +#include "controllerservices/AzureStorageCredentialsService.h" + +class AzureObjectFactory : public core::ObjectFactory { + public: + AzureObjectFactory() = default; + + /** + * Gets the name of the object. + * @return class name of processor + */ + std::string getName() override { + return "AzureObjectFactory"; + } + + std::string getClassName() override { + return "AzureObjectFactory"; + } + + /** + * Gets the class name for the object + * @return class name for the processor. + */ + std::vector<std::string> getClassNames() override { + std::vector<std::string> class_names; + class_names.push_back("AzureStorageCredentialsService"); + return class_names; + } + + std::unique_ptr<ObjectFactory> assign(const std::string &class_name) override { + if (utils::StringUtils::equalsIgnoreCase(class_name, "AzureStorageCredentialsService")) { + return minifi::utils::make_unique<core::DefautObjectFactory<minifi::azure::controllers::AzureStorageCredentialsService>>(); + } else { + return nullptr; + } + } + + static bool added; +}; + +extern "C" { +DLL_EXPORT void *createAzureFactory(void); Review comment: It is supposed to be the explicit way of saying the function "takes no parameters" as opposed to "taking an unspecified number of arguments of unspecified type" in C according to https://stackoverflow.com/questions/51032/is-there-a-difference-between-foovoid-and-foo-in-c-or-c ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
