simonbence commented on a change in pull request #4883:
URL: https://github.com/apache/nifi/pull/4883#discussion_r592156726
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/status/history/EmbeddedQuestDbRolloverHandlerTest.java
##########
@@ -198,10 +292,14 @@ private void thenRemainingPartitionsAre(final
List<Integer> expectedDays) throws
existingPartitions.add(new
StringBuilder(record.getStr(0)).toString());
}
- Assert.assertEquals(expectedPartitions.size(),
existingPartitions.size());
+ Assert.assertEquals(expectedPartitions.length,
existingPartitions.size());
for (final String expectedPartition : expectedPartitions) {
Assert.assertTrue("Partition " + expectedPartition + " is
expected", existingPartitions.contains(expectedPartition));
}
}
+
+ private void thenNoPartitionsExpected() throws Exception {
+ thenTheRemainingPartitionsAre();
+ }
}
Review comment:
Sorry, but where the extra newline is expected? (I checked the
surrounding classes around, and the ones I checked neither have newline at the
end of the file or after the last method)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
