[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1020: MINIFICPP-1352 Enable -Wall and -Wextra and resolve related warnings

[GitBox]

szaszm commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r592207117



##########
File path: extensions/script/python/PythonScriptEngine.cpp
##########
@@ -33,7 +33,7 @@ Interpreter *getInterpreter() {
 }
 
 PythonScriptEngine::PythonScriptEngine() {
-  auto intepreter = getInterpreter();
+  getInterpreter();

Review comment:
       You're right, the `py::scoped_interpreter` member of `Interpreter` is 
actually initializing global state. Nevermind.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org