exceptionfactory commented on a change in pull request #4892:
URL: https://github.com/apache/nifi/pull/4892#discussion_r593392978
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -674,20 +661,11 @@ public void onPropertyModified(final PropertyDescriptor
descriptor, final String
ProxyConfiguration.validateProxySpec(validationContext, results,
PROXY_SPECS);
- for (String headerKey : validationContext.getProperties().values()) {
- if (excludedHeaders.containsKey(headerKey)) {
- // We're not using the header message format string here, just
this
- // static validation message string:
- results.add(new
ValidationResult.Builder().subject(headerKey).valid(false).explanation("Matches
excluded HTTP header name").build());
- }
- }
-
Review comment:
This validation block was related to the `excludedHeaders` check.
However, the way this was written, it was not actually working properly since
`getProperties().values()` returns property _values_ instead of property
_names_. If the check for `Trusted Hostname` is absolutely necessary, this
could be corrected, but I recommend removing all references.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
