szaszm commented on a change in pull request #1028:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595820660
##########
File path: libminifi/src/FlowFileRecord.cpp
##########
@@ -181,12 +179,12 @@ std::shared_ptr<FlowFileRecord>
FlowFileRecord::DeSerialize(io::InputStream& inS
}
ret = inStream.read(file->uuid_);
- if (ret <= 0) {
+ if (ret == static_cast<size_t>(-1)) {
Review comment:
Definitely an oversight, will fix. If you find other suspicious places,
feel free to point out. I might have missed some in the 100+ "Find usages"
results.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
