[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

[GitBox]

fgerlits commented on a change in pull request #1028:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596166085



##########
File path: libminifi/test/rocksdb-tests/ContentSessionTests.cpp
##########
@@ -56,11 +56,10 @@ const std::shared_ptr<minifi::io::BaseStream>& 
operator>>(const std::shared_ptr<
   str = "";
   uint8_t buffer[4096]{};
   while (true) {
-    size_t ret = stream->read(buffer, sizeof(buffer));
+    const auto ret = stream->read(buffer, sizeof(buffer));
     REQUIRE(ret >= 0);

Review comment:
       ```suggestion
       REQUIRE(!minifi::io::isError(ret));
   ```

##########
File path: libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp
##########
@@ -179,7 +179,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]") {
 
   std::string readstr;
 
-  // -1 tell us we have an invalid stream
+  // error tells us we have an invalid stream

Review comment:
       it would be better to remove this comment, as we don't check for error 
here (also at line 230)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org