[ https://issues.apache.org/jira/browse/NIFI-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15564968#comment-15564968 ]
ASF GitHub Bot commented on NIFI-2863: -------------------------------------- GitHub user ijokarumawak opened a pull request: https://github.com/apache/nifi/pull/1122 NIFI-2863: S2S to allow cluster URL more leniently Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. - Consolidated the target cluster URL resolving logic into SiteToSiteRestApiClient's as a common method - Added more unit test cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijokarumawak/nifi nifi-2863 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1122.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1122 ---- commit f56e968baa3626693eb5f3983ae700b60a838ccb Author: Koji Kawamura <ijokaruma...@apache.org> Date: 2016-10-11T08:07:05Z NIFI-2863: S2S to allow cluster URL more leniently - Consolidated the target cluster URL resolving logic into SiteToSiteRestApiClient's as a common method - Added more unit test cases ---- > A remote process group pointed to a host without the trailing "/nifi" will > fail with mis-leading bulletins > ---------------------------------------------------------------------------------------------------------- > > Key: NIFI-2863 > URL: https://issues.apache.org/jira/browse/NIFI-2863 > Project: Apache NiFi > Issue Type: Bug > Reporter: Joseph Percivall > Assignee: Koji Kawamura > > To replicate: > 1: Set up NiFi instance on port 8080 and remote port 8081 (unsecure S2S) > 2: create input port > 3: create RPG pointing to "http://localhost:8080" > This RPG will correctly get the instance name, listing of ports and port > status but when transmission is enabled and a flowfile is queued to be sent > the following error is generated: > "RemoteGroupPort[name=test1,target=http://localhost:8080] failed to > communicate with http://localhost:8080 due to > org.codehaus.jackson.JsonParseException: Unexpected character ('<' (code > 60)): expected a valid value (number, String, array, object, 'true', 'false' > or 'null') > at [Source: java.io.StringReader@44d519ce; line: 3, column: 2]" > Looking at the logs there is this message: > 2016-10-04 14:11:34,298 WARN [Timer-Driven Process Thread-2] > o.a.n.r.util.SiteToSiteRestApiClient Failed to parse Json, response= > <!DOCTYPE html> > <html> > <head> > <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> > <link rel="shortcut icon" href="/nifi/images/nifi16.ico"/> > <title>NiFi</title> > <link rel="stylesheet" href="/nifi/css/reset.css" type="text/css" /> > <link rel="stylesheet" href="/nifi/css/common-ui.css" type="text/css" > /> > <link rel="stylesheet" href="/nifi/fonts/flowfont/flowfont.css" > type="text/css" /> > <link rel="stylesheet" > href="/nifi/assets/font-awesome/css/font-awesome.min.css" type="text/css" /> > <link rel="stylesheet" href="/nifi/css/message-pane.css" > type="text/css" /> > <link rel="stylesheet" href="/nifi/css/message-page.css" > type="text/css" /> > </head> > <body class="message-pane"> > <div class="message-pane-message-box"> > <p class="message-pane-title"> > Did you mean: <a href="/nifi/">/nifi</a> > </p> > <p class="message-pane-content">You may have mistyped...</p> > </div> > </body> > </html> > 2016-10-04 14:11:34,298 ERROR [Timer-Driven Process Thread-2] > o.a.nifi.remote.StandardRemoteGroupPort > RemoteGroupPort[name=test1,target=http://localhost:8080] failed to > communicate with http://localhost:8080 due to > org.codehaus.jackson.JsonParseException: Unexpected character ('<' (code > 60)): expected a valid value (number, String, array, object, 'true', 'false' > or 'null') > at [Source: java.io.StringReader@44d519ce; line: 3, column: 2] > This should either be fixed (to allow without "/nifi") or explicitly > validated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)