fgerlits commented on a change in pull request #1037:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1037#discussion_r600522506
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -541,6 +543,11 @@ void PublishKafka::onSchedule(const
std::shared_ptr<core::ProcessContext> &conte
conn_ = utils::make_unique<KafkaConnection>(key_);
configureNewConnection(context);
+ std::string message_key_field;
+ if (context->getProperty(MessageKeyField.getName(), message_key_field)) {
+ logger_->log_error("The %s property is set. This property is DEPRECATED
and has no effect; please use Kafka Key instead.", MessageKeyField.getName());
Review comment:
I'm fine with logging it on either warning or error level, so we'll need
a 4th vote to decide. :)
My reasoning for an error log was that if the user has set the
MessageKeyField property, then their flow is not working as intended. E.g.
they may have wanted to set the message key to the value of a particular flow
file attribute, but it is set to the flow file UUID instead -- this can cause
difficult-to-debug problems down the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
