Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/239
  
    @mans2singh thanks for the displayName, namespace, and test doc changes.
    * **Logging** - I'm mostly comfortable with the logging as-is, I certainly 
agree with your point about most problems being up-front configuration.  Would 
it be OK to move the exception message before the listing of the flowfiles 
(PutKinesis.java:168)?  I think it would be easier to understand problems in 
bulletins on the processor, while still leaving the flowfile detail.
    * **Naming** - Changing the naming does seem appropriate, to mirror what 
you have already done with Kinesis Firehose.  Would you please rename
     - PutKinesis to PutKinesisStream (or similar)
     - AbstractKinesisProcessor to AbstractKinesisStreamProcessor (or similar)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to