Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1125
@vegaed thanks for putting this together. I have a few initial suggestions
from a quick scan:
* Please run `mvn clean install -Pcontrib-check` - there are a few issues
with .* imports, unused imports, etc.
* Did you forget to incude an entry for PutCloudWatchMetric processor in
the service definition file org.apache.nifi.processor.Processor?
* For PropertyDescriptors, please provide both `name` (as a data key) and
`displayName` (for UI presentation)
* Why not use REL_SUCCESS and REL_FAILURE inherited from
AbstractAWSProcessor? The descriptions would be less specific, but it appears
to be a standard practice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
