[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1032: MINIFICPP-1504: Add Resource consumption data to heartbeats

[GitBox]

martinzink commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603124037



##########
File path: libminifi/include/core/state/Value.h
##########
@@ -228,36 +225,36 @@ class IntValue : public Value {
   }
 
  protected:
-  virtual bool getValue(int &ref) {
+  bool getValue(int &ref) override {
     ref = value;
     return true;
   }
 
-  virtual bool getValue(uint32_t &ref) {
+  bool getValue(uint32_t &ref) override {
     if (value < 0)
       return false;
     ref = value;
     return true;
   }
 
-  virtual bool getValue(int64_t &ref) {
+  bool getValue(int64_t &ref) override {
     ref = value;
     return true;
   }
 
-  virtual bool getValue(uint64_t &ref) {
+  bool getValue(uint64_t &ref) override {
     if (value < 0)

Review comment:
       We could, I left these signed into longer unsigned as is because they 
could be confidently casted with one if.
   Of course making everything the same could make this more readable. Should I 
change it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org