ottobackwards commented on a change in pull request #1026: URL: https://github.com/apache/nifi-minifi-cpp/pull/1026#discussion_r604258192
########## File path: README.md ########## @@ -591,6 +591,10 @@ We welcome all contributions to Apache MiNiFi. To make development easier, we've the linter for the Google Style guide. Google provides an Eclipse formatter for their style guide. It is located [here](https://github.com/google/styleguide/blob/gh-pages/eclipse-cpp-google-style.xml). New contributions are expected to follow the Google style guide when it is reasonable. + Review comment: for example ( this may be overkill obviously), I have this in my headers: ```bash # This script is verified by shellcode. Any suppressions shall be listed here # with the reason for suppression. # # | shellcode error number | reason for suppression | # |---------------------------------------------------------------------------| # example "because" # ################################################################################ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
