markap14 commented on a change in pull request #4950:
URL: https://github.com/apache/nifi/pull/4950#discussion_r608121946



##########
File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/nifi-stateless-bootstrap/src/main/java/org/apache/nifi/stateless/bootstrap/StatelessBootstrap.java
##########
@@ -98,7 +99,12 @@ public static StatelessBootstrap bootstrap(final 
StatelessEngineConfiguration en
         // Unpack NARs
         final long unpackStart = System.currentTimeMillis();
         final Predicate<BundleCoordinate> narFilter = coordinate -> true;
-        NarUnpacker.unpackNars(systemBundle, frameworkWorkingDir, 
extensionsWorkingDir, null, narDirectories, false, false, false, narFilter);
+        NarUnpackLock.lock();

Review comment:
       No, each process that needs the nar will download it for itself. They 
download using a temporary filename. Only one task will manage to rename its 
download to the 'final' name. Others will delete their temporary files. It's 
not efficient, but it was a simple/straight-forward solution that can be 
improved upon later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to