nabmoh123 commented on pull request #4939: URL: https://github.com/apache/nifi/pull/4939#issuecomment-814967533
> I still think that a custom validate method makes sense. Especially to make the processor invalid if brokers, host, and port are all set. Because in that case it could confuse the users wrt to which properties are actually used. I acknowledge this is explained in the properties description but this would make things more "obvious". > > We do that for some processors where it's possible to configure the same "thing" via multiple properties after we added some new properties over time and we kept the old ones to not break backward compatibility. > > That's my only remaining comment, latest changes look good to me. I could implement this, but it would require me to take off the default values for Host Name and Port. Otherwise, whenever Brokers is set, Host Name will take on its default value and cause a warning to appear. I'm not sure which is the lesser of two evils here, removing old functionality or not adding in clear and concise validation to ensure users understand which property is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
