adamdebreceni commented on a change in pull request #1042:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1042#discussion_r609396538



##########
File path: libminifi/src/ThreadedSchedulingAgent.cpp
##########
@@ -88,6 +88,7 @@ void 
ThreadedSchedulingAgent::schedule(std::shared_ptr<core::Processor> processo
 
   auto sessionFactory = 
std::make_shared<core::ProcessSessionFactory>(processContext);
 
+  processor->validateAnnotations();

Review comment:
       given our direction towards all kinds of flow-verification, this could 
be moved into either a `FlowController::verifyFlow(ProcessGroup&)` or 
`ProcessGroup::verify` (the former might be better as then we could access the 
services and repositories all at once) which could then be expanded as needed 
(calling it from `FlowController::load`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to