arpadboda commented on a change in pull request #1043:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1043#discussion_r609571094
##########
File path: extensions/http-curl/processors/InvokeHTTP.cpp
##########
@@ -75,7 +75,11 @@ core::Property InvokeHTTP::ReadTimeout(
core::Property InvokeHTTP::DateHeader(
core::PropertyBuilder::createProperty("Include Date
Header")->withDescription("Include an RFC-2616 Date header in the
request.")->isRequired(false)->withDefaultValue<bool>(true)->build());
-core::Property InvokeHTTP::FollowRedirects("Follow Redirects", "Follow HTTP
redirects issued by remote server.", "True");
+core::Property InvokeHTTP::FollowRedirects(
+ core::PropertyBuilder::createProperty("Follow Redirects")
+ ->withDescription("Follow HTTP redirects issued by remote server.")
+ ->withDefaultValue<bool>(true)
Review comment:
According to Curl, this is false by default:
https://curl.se/libcurl/c/CURLOPT_FOLLOWLOCATION.html
So I think this is a breaking change, I would prefer to have false here by
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
