lordgamez commented on a change in pull request #1031:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1031#discussion_r609590787
##########
File path: extensions/aws/processors/PutS3Object.cpp
##########
@@ -206,7 +206,8 @@
minifi::utils::optional<aws::s3::PutObjectRequestParameters> PutS3Object::buildP
const std::shared_ptr<core::ProcessContext> &context,
const std::shared_ptr<core::FlowFile> &flow_file,
const CommonProperties &common_properties) {
- aws::s3::PutObjectRequestParameters params;
+ aws::s3::PutObjectRequestParameters params(common_properties.credentials,
client_config_);
+ setClientConfig(params.client_config, common_properties);
Review comment:
Thanks, for the suggestion, I like the idea, added it in
21f8e90a07c8d47da881fcae5abb4d74e5f3657a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
