jfrazee commented on pull request #4576:
URL: https://github.com/apache/nifi/pull/4576#issuecomment-816187172


   @pkelly-nifi I tested `FetchGCSObject` using the 
[`LocalStorageHelper`](https://github.com/googleapis/java-storage-nio/blob/master/google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/testing/LocalStorageHelper.java)
 from Google's java-storage-nio and all the test cases except one pass.
   
   Right now, if you provide a range start that is larger than the content, it 
routes a zero-length string to `REL_SUCCESS`. This is not the same behavior for 
the other processors.
   
   AFAICT, this isn't a quirk of the `LocalStorageHelper`. 
[`BlobReadChannel`](https://github.com/googleapis/java-storage/blob/master/google-cloud-storage/src/main/java/com/google/cloud/storage/BlobReadChannel)
 doesn't seem to care if you seek past the size of the content.
   
   So question, do we allow different behavior since the cloud providers are 
different and this apparently isn't an issue for GCS, or do we enforce some 
consistency and check against the length in the blob metadata? I think it 
should be the latter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to