[ https://issues.apache.org/jira/browse/NIFI-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15571004#comment-15571004 ]
ASF GitHub Bot commented on NIFI-2861: -------------------------------------- GitHub user jskora opened a pull request: https://github.com/apache/nifi/pull/1128 NIFI-2861 ControlRate should accept more than one flow file per execution (0.x) Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. * Support multiple files per onTrigger call. (0.x branch) You can merge this pull request into a Git repository by running: $ git pull https://github.com/jskora/nifi NIFI-2861-0.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1128.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1128 ---- commit 9d4a6e742bc67838176756bb7ef600e54d2904df Author: Joe Skora <jsk...@gmail.com> Date: 2016-10-13T06:18:23Z NIFI-2861 ControlRate should accept more than one flow file per execution * Support multiple files per onTrigger call. (0.x branch) ---- > ControlRate should accept more than one flow file per execution > --------------------------------------------------------------- > > Key: NIFI-2861 > URL: https://issues.apache.org/jira/browse/NIFI-2861 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework > Affects Versions: 1.0.0, 0.7.0 > Reporter: Joe Skora > Assignee: Joe Skora > > The {{ControlRate}} processor implements a {{FlowFileFilter}} that returns > the {{FlowFileFilter.ACCEPT_AND_TERMINATE}} result if the {{FlowFile}} fits > with the rate limit, affectively limiting it to one {{FlowFile}} per > {{ConrolRate.onTrigger()}} invocation. This is a significant bottleneck when > processing very large quantities of small files making it unlikely to hit the > rate limits. > It should allow multiple files, perhaps with a configurable maximum, per > {{ControlRate.onTrigger()}} invocation by issuing the > {{FlowFileFilter.ACCEPT_AND_CONTINUE}} result until the limits are reached. > In a preliminary test this eliminated the bottleneck. -- This message was sent by Atlassian JIRA (v6.3.4#6332)