fgerlits commented on a change in pull request #1045: URL: https://github.com/apache/nifi-minifi-cpp/pull/1045#discussion_r612369176
########## File path: libminifi/include/core/ProcessGroup.h ########## @@ -57,7 +60,12 @@ enum ProcessGroupType { // ProcessGroup Class class ProcessGroup : public CoreComponent { + friend struct ::TestAccessor; Review comment: `TestAccessor` could have a more specific name like `ProcessGroupTestAccessor`, especially since it is in the global namespace EDIT: `TestAccessor` doesn't exist, so a better solution would be to remove both declarations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org