Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1108
@selim-namsi Thanks for contributing this! I have actually been very
interested in using NiFi to do some log parsing but hadn't really dug in very
much to understand the best way to go about it. This looks like it could be
very powerful!
Before we get this merged into the codebase, though, it looks like there is
some work that needs to be done to the PR. The concern stems, I think, from you
not yet being overly familiar with the API, as there are empty
@ReadsAttributes, @WritesAttributes annotations, etc. But the great news is
that the NiFi community tends to be very inclusive and will help to get
everything in great shape!
One thing that I did notice is that you updated the Licensing information,
which is one of the most commonly overlooked issues. So very glad that's there.
I'll leave some inline feedback on things that I notice, but very much looking
forward to this getting in!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
