markap14 commented on a change in pull request #5042:
URL: https://github.com/apache/nifi/pull/5042#discussion_r625987385
##########
File path:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java
##########
@@ -574,9 +572,10 @@ public void handle(final byte[] rowKey, final ResultCell[]
resultCells) {
// we could potentially have a huge number of rows. If we get
to batchSize, go ahead and commit the
// session so that we can avoid buffering tons of FlowFiles
without ever sending any out.
if (getBatchSize()>0 && ffUncommittedCount*bulkSize >
getBatchSize()) {
- session.commit();
- ffCountHolder.set(0L);
- }else{
+ session.commitAsync(() -> {
+ ffCountHolder.set(0L);
Review comment:
Should be fine. As mentioned in comment above, the documentation that I
wrote was outdated. Reuse of the session should be okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
