fgerlits commented on a change in pull request #1064:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630912957
##########
File path: extensions/standard-processors/processors/GetFile.cpp
##########
@@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext *context,
core::ProcessSessionFact
request_.inputDirectory = value;
}
-void GetFile::onTrigger(core::ProcessContext* /*context*/,
core::ProcessSession *session) {
- // Perform directory list
-
+void GetFile::onTrigger(core::ProcessContext* /*context*/,
core::ProcessSession* session) {
metrics_->iterations_++;
- const bool isDirEmptyBeforePoll = isListingEmpty();
- logger_->log_debug("Is listing empty before polling directory %i",
isDirEmptyBeforePoll);
- if (isDirEmptyBeforePoll) {
+ const bool is_dir_empty_before_poll = isListingEmpty();
+ logger_->log_debug("Listing is %s before polling directory",
is_dir_empty_before_poll ? "empty" : "not empty");
Review comment:
I'll change it if you think saving 5 chars in the line (and 5 bytes in
the code) is worth it, but I think it is more readable this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
