harjitdotsingh commented on pull request #5046: URL: https://github.com/apache/nifi/pull/5046#issuecomment-839768161
I knew that was coming. For some reasons my IDE formatted the code. Let me fix that. I will add that. I didn't see tests for any other cases other than JSON so left it but let me see if I can find some sample files for Parquet,ORC and DataStoreBackup. Thanks - harjit On Wed, May 12, 2021 at 7:02 AM Pierre Villard ***@***.***> wrote: > Hi @harjitdotsingh <https://github.com/harjitdotsingh> - happy to review > these changes but can you make sure the PR is only changing what needs to > be changed? there is a lot of formatting related changes that are making > the review harder. Can we also have tests for the changes? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/nifi/pull/5046#issuecomment-839680947>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAASJ7WPKQTSTZRZPFNYKTTTNJN5NANCNFSM434PUOGQ> > . > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
