mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-840183039


   Pushed commits that addresses all remaining changes and PR feedback. The PR 
is ready for a full review. 
   @sardell Would you review the frontend changes?
   
   Recent changes include:
   
   - Changed the dialog title from 'Download Version' to 'Export Version' and 
refactored the component. @bbende @andrewmlim @moranr Thanks for the feedback 
and agreed 'Export' seems more consistent  
   
   - Changed the 'Export Version' dialog dropdown menu item to "Latest (Version 
#)"
   - Changed the Actions menu hover style to differentiate from the focus style
   - Added frontend tests. Note - With the way Angular and Javascript is 
currently configured in Registry, I had issues writing certain tests for the 
new components. It's been captured in a JIRA ticket: 
[NIFIREG-454](https://issues.apache.org/jira/browse/NIFIREG-454). Once 
resolved, more tests can be added.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to