mattyb149 commented on pull request #5075:
URL: https://github.com/apache/nifi/pull/5075#issuecomment-840642467
This looks good to me but would like to see a unit test, you could
add/change the following in TestPrometheusRecordSink.initTask() for example:
```
final MockVariableRegistry variableRegistry = new MockVariableRegistry();
variableRegistry.setVariable(new VariableDescriptor("port"), "7077");
when(context.getProperty(PrometheusMetricsUtil.METRICS_ENDPOINT_PORT)).thenReturn(new
MockPropertyValue("${port}", null, variableRegistry));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
