fgerlits opened a new pull request #1080: URL: https://github.com/apache/nifi-minifi-cpp/pull/1080
https://issues.apache.org/jira/browse/MINIFICPP-1559 Visual Studio 2019 contains a new redistributable DLL, `vcruntime140_1.dll`, which is required by VS2019 MiNiFi builds but was not included in the MSI package. I have added it (in VS2019 builds only). NOTE: there are two other new DLLs in the VS2019 redistributable directory, `msvcp140_atomic_wait.dll` and `msvcp140_codecvt_ids.dll`. I did not include these, as our current build does not require them. Should we include these, too? --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically main)? - [x] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
