szaszm commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r638895278
########## File path: libminifi/include/utils/MathUtils.h ########## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#pragma once + +#include <math.h> + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace utils { + +class MathUtils { + public: + static double round_to(double original, int8_t precision) { + if (precision < 0) { + return original; Review comment: Rounding to fractional decimal places like 10^-2 => 123.45 makes sense as well. Either implement the full expected behavior or move the implementation to somewhere local near the usage, so it's clear that this logic is related to the performance monitor functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
