[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

[GitBox]

martinzink commented on a change in pull request #1081:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640503174



##########
File path: extensions/pdh/PerformanceDataMonitor.cpp
##########
@@ -45,9 +45,13 @@ core::Property PerformanceDataMonitor::CustomPDHCounters(
 core::Property PerformanceDataMonitor::OutputFormatProperty(
     core::PropertyBuilder::createProperty("Output Format")->
     withDescription("Format of the created flowfiles")->
-    withAllowableValue<std::string>(JSON_FORMAT_STR)->
-    withAllowableValue(OPEN_TELEMETRY_FORMAT_STR)->
-    withDefaultValue(JSON_FORMAT_STR)->build());
+    withAllowableValues<std::string>({ PRETTY_JSON_FORMAT_STR, 
COMPACT_JSON_FORMAT_STR, PRETTY_OPEN_TELEMETRY_FORMAT_STR, 
COMPACT_OPEN_TELEMETRY_FORMAT_STR })->
+    withDefaultValue(PRETTY_JSON_FORMAT_STR)->build());
+
+core::Property PerformanceDataMonitor::DecimalPlaces(
+  core::PropertyBuilder::createProperty("Round to decimal places")->
+  withDescription("The number of decimal places to round the values to (blank 
for no rounding)")->
+  withDefaultValue("3")->build());

Review comment:
       I was able to set empty string during testing with c2 protocoll, but 
changed it to blank nontheless thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org