[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

[GitBox]

adamdebreceni commented on a change in pull request #1083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643109029



##########
File path: extensions/libarchive/CompressContent.h
##########
@@ -386,7 +386,7 @@ class CompressContent : public core::Processor {
               if (io::isError(writeret) || gsl::narrow<size_t>(writeret) != 
ret) {
                 return -1;
               }
-              read_size += ret;
+              read_size += gsl::narrow<int64_t>(ret);

Review comment:
       could we change `read_size`'s type to `size_t`? then we could get rid of 
two narrows (and introduce one in the return :( )




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org