[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

[GitBox]

szaszm commented on a change in pull request #1083:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643987158



##########
File path: libminifi/test/rocksdb-tests/RocksDBStreamTests.cpp
##########
@@ -45,7 +45,9 @@ TEST_CASE_METHOD(RocksDBStreamTest, "Verify simple 
operation") {
   std::string content = "banana";
   minifi::io::RocksDbStream outStream("one", gsl::make_not_null(db.get()), 
true);
   outStream.write(content);
-  REQUIRE(outStream.write(content) > 0);
+  const auto second_write_result = outStream.write(content);
+  REQUIRE(second_write_result > 0);
+  REQUIRE(!minifi::io::isError(second_write_result));

Review comment:
       changed to REQUIRE_FALSE in 5c6ba7b




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org