Lehel44 commented on a change in pull request #5115:
URL: https://github.com/apache/nifi/pull/5115#discussion_r643997332
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java
##########
@@ -90,14 +91,20 @@
+ " that the memory pool is exceeding this threshold.")
public class MonitorMemory extends AbstractReportingTask {
+ private static final List<String> GC_OLD_GEN_POOLS =
Arrays.asList("Tenured Gen", "PS Old Gen", "G1 Old Gen", "CMS Old Gen",
"ZHeap");
private static final AllowableValue[] memPoolAllowableValues;
+ private static String defaultMemoryPool;
static {
// Only allow memory pool beans that support usage thresholds,
otherwise we wouldn't report anything anyway
List<MemoryPoolMXBean> memoryPoolBeans =
ManagementFactory.getMemoryPoolMXBeans().stream().filter(MemoryPoolMXBean::isUsageThresholdSupported).collect(Collectors.toList());
memPoolAllowableValues = new AllowableValue[memoryPoolBeans.size()];
for (int i = 0; i < memPoolAllowableValues.length; i++) {
- memPoolAllowableValues[i] = new
AllowableValue(memoryPoolBeans.get(i).getName());
+ final String poolName = memoryPoolBeans.get(i).getName();
+ if (defaultMemoryPool == null &&
GC_OLD_GEN_POOLS.contains(poolName)) {
Review comment:
I think defaultMemoryPool is always null at the time of static
initialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
